Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateQuery on ObservedQuery #506

Merged
merged 3 commits into from
Aug 4, 2016
Merged

updateQuery on ObservedQuery #506

merged 3 commits into from
Aug 4, 2016

Conversation

Slava
Copy link
Contributor

@Slava Slava commented Aug 3, 2016 •
edited
Loading

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@Slava
Copy link
Contributor Author

Slava commented Aug 3, 2016

Since the logic of this method is tested by fetchMore, new tests seem to be redundant?

@stubailo

stubailo
stubailo reviewed Aug 3, 2016
View reviewed changes
CHANGELOG.md
@@ -5,6 +5,7 @@ Expect active development and potentially significant breaking changes in the `0
### vNEXT
- Added an `refetchQueries` option to `mutate`. The point is to just refetch certain queries on a mutation rather than having to manually specify how the result should be incorporated for each of them with `updateQueries`. [PR #482](https://github.com/apollostack/apollo-client/pull/482) and [Issue #448](https://github.com/apollostack/apollo-client/issues/448).
- Print errors produced by application-supplied reducer functions passed to `updateQueries` or `updateQuery` options for `mutate` or `fetchMore` respectively. [PR #500](https://github.com/apollostack/apollo-client/pull/500) and [Issue #479](https://github.com/apollostack/apollo-client/issues/479).
- Added an `updateQuery` method on observable queries. Allows application code to arbitrary change the result of a query normalized to store, without issuing any network requests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add PR and issue links

@stubailo
Copy link
Contributor

stubailo commented Aug 3, 2016

Also, add one test just to have a sanity check.

@Slava Slava mentioned this pull request Aug 4, 2016
Closed
@stubailo stubailo merged commit 7037195 into master Aug 4, 2016
@joarwilk joarwilk mentioned this pull request Aug 18, 2016
Closed
@stubailo stubailo deleted the update-query branch September 20, 2016 03:42
@snyk-bot snyk-bot mentioned this pull request Feb 21, 2022
Open
@NOUIY NOUIY mentioned this pull request Apr 21, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Slava @stubailo