Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect used variables in directives #563

Merged
merged 3 commits into from
Aug 19, 2016
Merged

Collect used variables in directives #563

merged 3 commits into from
Aug 19, 2016

Conversation

rricard
Copy link
Contributor

@rricard rricard commented Aug 19, 2016 •
edited
Loading

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Fixes #562

@rricard rricard added ready and removed in progress labels Aug 19, 2016
@helfer
Copy link
Contributor

helfer commented Aug 19, 2016

Awesome, thanks a lot! I'll merge this before we publish the next version.

@stubailo
Copy link
Contributor

Just rebased and force pushed

@helfer helfer merged commit 4655a07 into master Aug 19, 2016
@helfer helfer removed the ready label Aug 19, 2016
@rricard rricard deleted the fix-562 branch August 20, 2016 09:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rricard @helfer @stubailo @zol