Make storing IDs in arrays consistent with the rest of the store #901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hacking around with some ideas for inspecting the store, and ran into a problem - ID references are not always stored the same way.
When it's an object field, the reference looks like:
When it's an array field, it's not wrapped at all:
This is problematic if one wants to write a tool that can follow query trees through the store. Looks like when we initially refactored to escape these IDs in the store, we didn't go all the way and totally forgot about arrays.
This PR fixes it to look like:
Note: This involved updating some of the old mutation behavior code. We should deprecate that and delete it/move it to an auxiliary package.
Questions:
TODO: