-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass ctx instead of ctx.request to koa options function #154
Conversation
@HriBB can you add that to the changelog? I think it's a good change, but it's a pretty major breaking change for the Koa integration. |
Done! |
@HriBB |
@mikeifomin you're right, thanks! @helfer should I add a test for that? |
@HriBB I don't even know how we could test for missing (type) exports. If you figure out a way to do that, I definitely want to know! |
Should be fixed now, @mikeifomin can you check? @helfer yeah I'm not very experienced with tests. I proposed that because I ran tests after fixing the |
@HriBB @mikeifomin is this ready to merge? |
@helfer yes! |
So how do we release this? Bump to v0.4? |
@stubailo yeah, we could release this before the monorepo, which would then be version 0.5 |
OK, will do. |
This is a breaking change. We need to mention this in the changelog.
TODO: