Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Promise for addSchemaLevelResolver #199

Merged
merged 1 commit into from
Nov 23, 2016
Merged

Conversation

ephemer
Copy link
Contributor

@ephemer ephemer commented Nov 14, 2016

Resolve Promise in schema level resolver if one is returned, conforming to behaviour of all other resolvers.

This should cause no change in current functionality, due to the use of Promise.resolve.

Resolve `Promise` in schema level resolver if one is returned, conforming to behaviour of other resolvers.
Copy link
Contributor

@DxCx DxCx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@smowden
Copy link

smowden commented Nov 22, 2016

any chance this will be merged soon?

@DxCx
Copy link
Contributor

DxCx commented Nov 22, 2016

I already reviewed it, looks good.
@helfer / @stubailo can we merge?

@stubailo stubailo merged commit 58bda27 into ardatan:master Nov 23, 2016
@stubailo
Copy link
Contributor

Thanks a lot! Sorry been distracted with other stuff last week.

@ephemer
Copy link
Contributor Author

ephemer commented Nov 23, 2016

🎉🎉 thanks guys

@ephemer ephemer deleted the patch-1 branch November 23, 2016 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants