This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Update to apollo client 0.4.0 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 12, 2016 11:09
| return false; | ||
| } else if (oldQueries) { | ||
| // unsubscribe from previous queries | ||
| this.unsubcribeAllQueries(); | ||
| } | ||
|
|
||
| if (isObject(queryHandles) && Object.keys(queryHandles).length) { | ||
| this.queryHandles = queryHandles; |
There was a problem hiding this comment.
As far as I know, this line was not correct - it was assigning query options to the same object we use to hold the observables/handles/subscriptions.
|
@stubailo thank you so much for doing this! |
stubailo
changed the title
|
@jbaxleyiii I think it's ready to merge as soon as you have time to look it over! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few hacks we should fixe before merging