Observable query refactor #211
Conversation
|
Also some of the commits you may want to cherry pick, especially e2b9587 |
| @@ -496,13 +496,16 @@ export interface UpdateQueryOptions { | |||
| } | |||
| export class ObservableQuery extends Observable<ApolloQueryResult> { | |||
| refetch: (variables?: any) => Promise<ApolloQueryResult>; | |||
| setVariables: (variables: any) => Promise<ApolloQueryResult>; | |||
There was a problem hiding this comment.
I manually copied this over from apollo-client -- I'm not sure what the correct procedure is.
|
@jbaxleyiii I think this is more or less done as I was hoping now. When you have a moment to look at this could you take a look? I'll wait for your approval before merging the changes to AC and ultimately these into RA. Also, you would have seen apollographql/apollo-client#707 which is relevant and something I'll look at soon. |
|
@tmeasday 🎉 awesome! I'll take some time today to investigate it and look around! |
tmeasday
force-pushed
the
observableQuery-refactor
branch
from
90e5e3e
to
16dece1
Compare
|
🎉 ready to go 🎉 |
|
@tmeasday I totally missed your rebase! I'm super sorry! I'll rebase it after the recent changes! |
|
@tmeasday |
|
@tmeasday fantastic work! |
|
Wow this is crazy! Awesome. |
@jbaxleyiii this is just a first pass for you to look at, still a bit more to do (see XXXs in code and some notes I will leave now).
I welcome any comments you have at this stage though!
(Note that this branch runs with the
add-observable-query-current-resultbranch of AC)