Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Use getApolloState instead relying on reduxRootKey #226

Merged
merged 1 commit into from
Sep 27, 2016

Conversation

sheerun
Copy link
Contributor

@sheerun sheerun commented Sep 22, 2016

I hope I got it well. It may or may not require major bump.

I'd be really glad if you released it asap, as I use my own redux store.

@apollo-cla
Copy link

@sheerun: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@sheerun sheerun force-pushed the redux-selector branch 4 times, most recently from 5318cd9 to 0540e54 Compare September 22, 2016 17:31
@sheerun
Copy link
Contributor Author

sheerun commented Sep 22, 2016

This is simpler and more accurate implementation of #223, should resolve #221

@sheerun
Copy link
Contributor Author

sheerun commented Sep 22, 2016

Actually it shoudn't require major bump as queryManager.getApolloState() was available in previous versions.

@stubailo
Copy link
Contributor

I'm a little uncomfortable because this isn't strictly a "public API" but it definitely works for now! We'll just need to be careful to not remove that function, or rename queryManager.

@sheerun
Copy link
Contributor Author

sheerun commented Sep 22, 2016

CI fails for non-related reasons.. I guess if you figure out public API for getting apollo state, you can change it. At least it's less hacky than manually fetching it by reduxRootSelector (that can be both string or function)... and backward compatible.

@stubailo
Copy link
Contributor

Yeah I think this is a great solution right now, let's do it!

@sheerun
Copy link
Contributor Author

sheerun commented Sep 26, 2016

@stubailo Any chance to release it soon? :)

@jbaxleyiii
Copy link
Contributor

@sheerun I'll get this out today!

@jbaxleyiii jbaxleyiii merged commit 4baa0f4 into apollographql:master Sep 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants