Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadataExtractor for each Monitor type should be packaged with the monitor type #501

Open
bvandewalle opened this issue Apr 3, 2018 · 0 comments

Comments

@bvandewalle
Copy link
Contributor

Having all the extractors on a completely separate package is weird to me and doesn't seen particulartly a good pattern as it distribute almost redundant code accross the monitor and extractor inplementation all over the place (such as helper functions).

I would suggest to move the extractors for each type in the same package as the monitor implementation itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant