Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Server Error when posting a permission while being authenticated with another permission #367

Open
VitaliiTsilnyk opened this issue Jan 17, 2023 · 0 comments
Assignees

Comments

@VitaliiTsilnyk
Copy link

VitaliiTsilnyk commented Jan 17, 2023

What version of ReactiveSearch API are you using ?

8.9.0

What issue did you run into?

  1. Create a permission (API Credentials) with a read-write access to the "permissions" category.
  2. Use the credentials of the just created permission in HTTP Basic Auth to send a POST /_permission request, trying to create another permission object.

What did you expect to see?

A created permission.

What did you see instead?

Internal server error saying "*user.User" not found in request context.

From what I was able to find in the code as a non-Go developer, looks like the user is being read from the context right here for the only purpose to check if it's admin or not, which decides the permission's default settings. And if the user not found, the error is being thrown.
Looking at the auth middleware I can see it being assigned only when the request is authenticated on behalf of a user. When you use API Credentials to authenticate the request, the permission is being assigned to the context instead.
I haven't found anywhere in the documentation that you can only create permissions when authenticated as a user. So I think it's a bug.
Would it be possible to fix it by assuming the user is not an admin if the request is authenticated with the API Credentials?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants