fix: Only check existence if firstMatch is applied #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Nov 25, 2022
## [4.10.10](v4.10.9...v4.10.10) (2022-11-25) ### Bug Fixes * Only check existence if firstMatch is applied ([#638](#638)) ([5394fe8](5394fe8))
|
🎉 This PR is included in version 4.10.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out allMatchingSnapshotsWithError: API is not invoked for firstMatch while it is for both allElementsBoundByIndex and allElementsBoundByAccessibilityElement calls. So it makes sense to only have existence check for element instances returned by firstMatch to have a decent lookup performance.