Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Drop workarounds for legacy iOS versions #696

Merged
merged 2 commits into from
May 14, 2023

Conversation

mykola-mokhnach
Copy link

The minimum supported iOS version is now 15, so we do not really care about the older stuff now

@KazuCocoa
Copy link
Member

KazuCocoa commented May 12, 2023

Can we bump the major version as well to make the drop kind of explicit by adding BREAKING CHANGE:?
(probably xcuitest driver is also good to bump the major version?)

Removing itself is 👍

@mykola-mokhnach
Copy link
Author

Can we bump the major version as well to make the drop kind of explicit by adding BREAKING CHANGE:? (probably xcuitest driver is also good to bump the major version?)

Removing itself is 👍

The change is not breaking because we officially stated way before that xcode 13 is the minimum supported version.

@jlipps what do you think?

@jlipps
Copy link
Member

jlipps commented May 12, 2023

Yeah this is a good question. Saying what we support and what we don't doesn't necessarily mean we shouldn't follow semver when enacting our support policies. Saying "we don't support iOS X anymore" is fine, but perhaps we should still release a new major version of the code so that users aren't surprised. If they complain, we point to the policy. In this case I think we should probably release as a breaking change.

@mykola-mokhnach
Copy link
Author

Yeah this is a good question. Saying what we support and what we don't doesn't necessarily mean we shouldn't follow semver when enacting our support policies. Saying "we don't support iOS X anymore" is fine, but perhaps we should still release a new major version of the code so that users aren't surprised. If they complain, we point to the policy. In this case I think we should probably release as a breaking change.

Then I would probably have multiple breaking changes. It would make sense to combine them and only bump the major version once

@mykola-mokhnach mykola-mokhnach changed the title chore: Drop workarounds for legacy iOS versions refactor: Drop workarounds for legacy iOS versions May 12, 2023
@jlipps
Copy link
Member

jlipps commented May 12, 2023

Then I would probably have multiple breaking changes. It would make sense to combine them and only bump the major version once

yeah makes sense

@mykola-mokhnach mykola-mokhnach merged commit bb562b9 into master May 14, 2023
@mykola-mokhnach mykola-mokhnach deleted the drop_legacy branch May 14, 2023 11:16
github-actions bot pushed a commit that referenced this pull request May 14, 2023
## [5.0.0](v4.15.1...v5.0.0) (2023-05-14)

### ⚠ BREAKING CHANGES

* The minimum supported xCode/iOS version is now 13/15.0

### Code Refactoring

* Drop workarounds for legacy iOS versions ([#696](#696)) ([bb562b9](bb562b9))
@github-actions
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants