feat: Add /calibrate endpoint #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebekebe
reviewed
Oct 5, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
## [5.11.0](v5.10.1...v5.11.0) (2023-10-05) ### Features * Add /calibrate endpoint ([#785](#785)) ([ae1603a](ae1603a))
|
🎉 This PR is included in version 5.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds GET /calibrate endpoint to WDA.
The idea is to use this special web page behind the endpoint to properly calibrate coordinates offset for nativeWebTap feature without applying ugly hacks like we do now.
Basically I am going to add
mobile: calibrateNativeToWebCoordinatesendpoint, which will only work in web/safari context and it will be loading this url to mobile Safari. Then we perform native click at the window center, which should also show actual web click coordinates. Then we can calculate the actual native/web coordinates delta and keep it to properly transform further native gesture coordinates. Ofc, the recalibration would be needed if the device changes orientation and there will be corner cases, but that method would be much more reliable in comparison to the ugly platform-dependent algorithm we use now in the xcuitest driver.Kudos to Benjamin Karran for sharing this great idea.