feat: use khidusage_keyboardclear to clear for iOS/iPad as the 1st attempt, tune tvOS
#811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
changed the title
clear for iOS/iPad as the 1st attemptclear for iOS/iPad as the 1st attempt, tune tvOS
| if (![FBKeyboard typeText:textToType error:error]) { | ||
|
|
||
| if (retry == 0) { | ||
| // 1st attempt is via the IOHIDEvent as a fastest operation |
mykola-mokhnach
approved these changes
Nov 10, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
## [5.14.0](v5.13.3...v5.14.0) (2023-11-10) ### Features * use khidusage_keyboardclear to `clear` for iOS/iPad as the 1st attempt, tune tvOS ([#811](#811)) ([dd093ea](dd093ea))
|
🎉 This PR is included in version 5.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appium/appium#19389
Based on #810
for iOS/iPad -> 1st attempt is via khidusage_keyboardclear, if this works, it is the fastest in my observation. The next is
typeTextthentapWithNumberOfTapstvOS ->
typeText:backspacesToTypethentypeText:backspaceDeleteSequenceIn tvOS's default search field had text, it was not placeholder. So it would be nice to minimize the retrial.