From 796585c993a947e7e94a67b3f49f2115ba3a2c0e Mon Sep 17 00:00:00 2001 From: Bryce Anderson Date: Thu, 8 Feb 2024 12:33:14 -0700 Subject: [PATCH] loadbalancer-experimental: make more interfaces public (#2829) Motivation: There were a few more interfaces that need to be public before things are really usable. Modifications: Make them public. --- .../io/servicetalk/loadbalancer/LoadBalancerBuilder.java | 2 +- .../io/servicetalk/loadbalancer/OutlierDetectorConfig.java | 6 +++++- .../servicetalk/loadbalancer/XdsHealthCheckerFactory.java | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancerBuilder.java b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancerBuilder.java index 44d6b013c8..07552c8f32 100644 --- a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancerBuilder.java +++ b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/LoadBalancerBuilder.java @@ -66,7 +66,7 @@ * @param The resolved address type. * @param The type of connection. */ -interface LoadBalancerBuilder { +public interface LoadBalancerBuilder { /** * Set the {@code loadBalancingPolicy} to use with this load balancer. * @param loadBalancingPolicy the {@code loadBalancingPolicy} to use diff --git a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/OutlierDetectorConfig.java b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/OutlierDetectorConfig.java index 2862faeb6a..f5c1669b0a 100644 --- a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/OutlierDetectorConfig.java +++ b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/OutlierDetectorConfig.java @@ -358,7 +358,11 @@ public static final class Builder { private boolean successfulActiveHealthCheckUnejectHost = true; - OutlierDetectorConfig build() { + /** + * Build the OutlierDetectorConfig. + * @return the OutlierDetectorConfig. + */ + public OutlierDetectorConfig build() { return new OutlierDetectorConfig(ewmaHalfLife, consecutive5xx, interval, baseEjectionTime, maxEjectionPercentage, enforcingConsecutive5xx, diff --git a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/XdsHealthCheckerFactory.java b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/XdsHealthCheckerFactory.java index 5a37c3acef..32bfe2f415 100644 --- a/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/XdsHealthCheckerFactory.java +++ b/servicetalk-loadbalancer-experimental/src/main/java/io/servicetalk/loadbalancer/XdsHealthCheckerFactory.java @@ -28,7 +28,7 @@ public final class XdsHealthCheckerFactory implements HealthChe private final OutlierDetectorConfig config; - XdsHealthCheckerFactory(final OutlierDetectorConfig config) { + public XdsHealthCheckerFactory(final OutlierDetectorConfig config) { this.config = requireNonNull(config, "config"); }