Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a swift-format check to run on PRs. #1719

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thomasvl
Copy link
Collaborator

Based off the swift-nio ones.

@thomasvl thomasvl force-pushed the swift-format_check branch 3 times, most recently from 4ddf45c to d66ae2c Compare September 20, 2024 20:29
@thomasvl thomasvl marked this pull request as ready for review September 20, 2024 20:30
@thomasvl
Copy link
Collaborator Author

Confirmed the check works with a edit in one of the pushes: https://github.com/apple/swift-protobuf/actions/runs/10965837593/job/30452496743

And https://github.com/apple/swift-protobuf/actions/runs/10965790445/job/30452355139 shows all the swift format lint warnings for why I disabled that.

@tbkka tbkka requested a review from Lukasa September 20, 2024 20:57
@thomasvl
Copy link
Collaborator Author

@Lukasa gentle ping

Based off the swift-nio ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant