Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the implementation with getting the default file path. Now it works with primary delay. #3

Closed
yelmuratoff opened this issue May 10, 2024 · 1 comment · Fixed by #7
Assignees
Labels
good first issue Good for newcomers in progress A label describing that this problem is currently being addressed. optimization Optimization problem

Comments

@yelmuratoff
Copy link
Collaborator

Describe the bug
Revise the implementation with getting the default file path. Now it works with primary delay.
At the moment, since the tests themselves are run in a temporary directory, so, we cannot use Platform.script to get access to the path of the running script we have to make numerous checks through the dcli library. Because of this, there is some delay at the beginning of the test launch.

To Reproduce
Steps to reproduce the behavior:
You can just use any method without specifying a file path.

Expected behavior
We need the standard path to be much faster than it would be in a normal environment, not a test environment.

It doesn't matter what device you test in. But I tested it on macOS and Windows.

For the original problem, there are already existing issues in the main repositories:

@yelmuratoff yelmuratoff added the optimization Optimization problem label May 10, 2024
@yelmuratoff yelmuratoff self-assigned this May 10, 2024
@yelmuratoff
Copy link
Collaborator Author

yelmuratoff commented May 15, 2024

Started to fix this problem without using third-party libraries.
Issue branch: https://github.com/approvals/ApprovalTests.Dart/tree/fix/script_path_issue

@yelmuratoff yelmuratoff added in progress A label describing that this problem is currently being addressed. good first issue Good for newcomers labels May 15, 2024
@yelmuratoff yelmuratoff linked a pull request May 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers in progress A label describing that this problem is currently being addressed. optimization Optimization problem
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant