Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 引数なしでVC参加するタイプのコマンドにstartサブコマンドを追加 #1111

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

MikuroXina
Copy link
Collaborator

Resolves #1040.

Type of Change:

機能の新規追加, テストの追加

Details of implementation (実施内容)

引数なしでボイスチャンネルに参加する方式だったコマンド群に対して, start サブコマンドでも参加するように機能を追加しました. またその場合でもこれまでと同じ動作になることを確かめるテストを追加しました.

@MikuroXina MikuroXina added C-bug Category: bug C-enhancement Category: enhancement C-improvement Category: improvement T-@oreorebot2/bot Type: OreOreBot2 Bot (packages/bot) labels Oct 4, 2023
@MikuroXina MikuroXina self-assigned this Oct 4, 2023
@MikuroXina MikuroXina requested a review from m1sk9 October 4, 2023 21:30
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #1111 (4a92f72) into main (bb03b54) will increase coverage by 0.13%.
The diff coverage is 60.46%.

@@            Coverage Diff             @@
##             main    #1111      +/-   ##
==========================================
+ Coverage   72.43%   72.57%   +0.13%     
==========================================
  Files          80       80              
  Lines        5464     5484      +20     
  Branches      486      487       +1     
==========================================
+ Hits         3958     3980      +22     
+ Misses       1021     1018       -3     
- Partials      485      486       +1     
Flag Coverage Δ
unittests 72.57% <60.46%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/bot/src/service/command/party.ts 83.13% <87.50%> (+0.34%) ⬆️
packages/bot/src/service/command/kaere.ts 73.06% <54.28%> (+1.67%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MikuroXina MikuroXina enabled auto-merge (squash) October 5, 2023 03:40
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4a92f72
Status:⚡️  Build in progress...

View logs

@MikuroXina MikuroXina merged commit 05a61b7 into main Oct 12, 2023
12 of 14 checks passed
@MikuroXina MikuroXina deleted the feat/#1040 branch October 12, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug C-enhancement Category: enhancement C-improvement Category: improvement T-@oreorebot2/bot Type: OreOreBot2 Bot (packages/bot)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

スラッシュコマンドから party, kaere が使用できない
2 participants