fix: ビルドバージョンの表示にVersionFetcherを使用するよう修正 #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikuroXina
added
C-bug
Deploying with
|
| Latest commit: |
fb17ea7
|
| Status: | ⚡️ Build in progress... |
Codecov Report
@@ Coverage Diff @@
## main #1114 +/- ##
=======================================
Coverage 72.43% 72.43%
=======================================
Files 80 80
Lines 5464 5464
Branches 486 486
=======================================
Hits 3958 3958
Misses 1021 1021
Partials 485 485
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
m1sk9
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #750.
Type of Change:
コードの修正
Details of implementation (実施内容)
process.env.npm_package_versionを使用していた箇所を,VersionFetcherオブジェクトが (package.json経由で) 取得したバージョン文字列に置き換えました.