Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 新時報システムの追加 #756

Merged
merged 14 commits into from
Feb 27, 2023
Merged

feat: 新時報システムの追加 #756

merged 14 commits into from
Feb 27, 2023

Conversation

MikuroXina
Copy link
Collaborator

Close #17.

Type of Change:

機能の追加, テストの追加

Details of implementation (実施内容)

#17 で提案していたものを追加しました. 時報スケジュールは assets/time-signal.yaml ファイルで 3 パターンを必ず指定するようになっており, 以下のような形式になっています.

MORNING: # キーはこの 3 パターンがすべて必須
  time:
    hours: 7   # 0 - 23 の数値
    minutes: 0 # 0 - 59 の数値
  message: 'マルナナマルマル、朝だ。…司令官、まだ寝てるの?'
NOON:
  time:
    hours: 12
    minutes: 0
  message: 'Полдень. 今日は何を作ってるんだい?'
MIDNIGHT:
  time:
    hours: 2
    minutes: 0
  message: 'マルフタマルマル、もう遅いね。眠かったらどうぞ。私の膝を貸そうか。'

@MikuroXina MikuroXina added the C-enhancement Category: enhancement label Feb 27, 2023
@MikuroXina MikuroXina self-assigned this Feb 27, 2023
@MikuroXina MikuroXina marked this pull request as draft February 27, 2023 10:07
@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2023

Codecov Report

Merging #756 (7ec38f7) into main (7dfca8a) will increase coverage by 0.32%.
The diff coverage is 90.38%.

❗ Current head 7ec38f7 differs from pull request most recent head 16fc20b. Consider uploading reports for the commit 16fc20b to get more accurate results

@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   72.35%   72.68%   +0.32%     
==========================================
  Files          71       72       +1     
  Lines        4800     4894      +94     
  Branches      466      474       +8     
==========================================
+ Hits         3473     3557      +84     
- Misses        862      864       +2     
- Partials      465      473       +8     
Flag Coverage Δ
unittests 72.68% <90.38%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/service/time-signal.ts 89.36% <89.36%> (ø)
src/adaptor/clock.ts 60.00% <100.00%> (ø)
src/adaptor/discord/voice.ts 21.00% <100.00%> (ø)
src/adaptor/proxy/command/schema.ts 55.12% <100.00%> (ø)
src/runner/schedule.ts 80.19% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MikuroXina MikuroXina marked this pull request as ready for review February 27, 2023 12:57
@MikuroXina MikuroXina merged commit 46bea77 into main Feb 27, 2023
@MikuroXina MikuroXina deleted the feat/#17 branch February 27, 2023 14:32
This was referenced Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

時報システムの復活
3 participants