-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: スラッシュコマンドの対応 #974
feat: スラッシュコマンドの対応 #974
Conversation
Deploying with Cloudflare Pages
|
Codecov Report
@@ Coverage Diff @@
## main #974 +/- ##
==========================================
- Coverage 73.92% 73.83% -0.09%
==========================================
Files 74 74
Lines 5077 5118 +41
Branches 452 453 +1
==========================================
+ Hits 3753 3779 +26
- Misses 873 887 +14
- Partials 451 452 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
レビューした分と合わせて一部のコマンドが正しく実行できないようです。
CombinedPropertyError: Received one or more errors
at ArrayValidator.handle (/Users/m1sk9/project/github.com/approvers/OreOreBot2/node_modules/@sapphire/shapeshift/src/validators/ArrayValidator.ts:102:17)
at ArrayValidator.parse (/Users/m1sk9/project/github.com/approvers/OreOreBot2/node_modules/@sapphire/shapeshift/src/validators/BaseValidator.ts:103:2)
at EmbedBuilder.spliceFields (/Users/m1sk9/project/github.com/approvers/OreOreBot2/node_modules/@discordjs/builders/src/messages/embed/Embed.ts:157:29)
at EmbedBuilder.setFields (/Users/m1sk9/project/github.com/approvers/OreOreBot2/node_modules/@discordjs/builders/src/messages/embed/Embed.ts:174:8)
at convertEmbed (file:///Users/m1sk9/project/github.com/approvers/OreOreBot2/src/adaptor/embed-convert.ts:31:11)
at Object.reply (file:///Users/m1sk9/project/github.com/approvers/OreOreBot2/src/adaptor/proxy/command.ts:146:20)
at ChannelInfo.on (file:///Users/m1sk9/project/github.com/approvers/OreOreBot2/src/service/command/channel-info.ts:52:19)
at processTicksAndRejections (node:internal/process/task_queues:95:5)
at async DiscordCommandProxy.onInteractionCreate (file:///Users/m1sk9/project/github.com/approvers/OreOreBot2/src/adaptor/proxy/command.ts:131:5) {
errors: [ [ 1, [CombinedPropertyError] ] ]
}
Error [InteractionAlreadyReplied]: The reply to this interaction has already been sent or deferred.
at ChatInputCommandInteraction.reply (/Users/m1sk9/project/github.com/approvers/OreOreBot2/node_modules/discord.js/src/structures/interfaces/InteractionResponses.js:102:46)
at Object.replyPages (file:///Users/m1sk9/project/github.com/approvers/OreOreBot2/src/adaptor/proxy/command.ts:215:37)
at HelpCommand.on (file:///Users/m1sk9/project/github.com/approvers/OreOreBot2/src/service/command/help.ts:33:19)
at file:///Users/m1sk9/project/github.com/approvers/OreOreBot2/src/runner/command.ts:26:17
at DiscordCommandProxy.onInteractionCreate (file:///Users/m1sk9/project/github.com/approvers/OreOreBot2/src/adaptor/proxy/command.ts:131:11)
at processTicksAndRejections (node:internal/process/task_queues:95:5) {
code: 'InteractionAlreadyReplied'
} |
CHANNEL の引数のパースができていなかったのを修正しました. また, |
Close #560.
Type of Change:
機能の追加, 環境変数の追加
Details of implementation (実施内容)
コマンドのスキーマの情報を元に, これらをスラッシュコマンドのスキーマへ加工して Discord API に送信するようにしました
この実装のために既存のコマンドのスキーマでは情報が不足していました. 根本的な対策として, スキーマの
interface
定義を改修し, 不足していたフィールドdescription
をそれぞれのスキーマの記述に追記しました.