Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrightCove has deprecated playback speed setup method used #26

Open
bryanlandia opened this issue Jul 24, 2018 · 1 comment
Open

BrightCove has deprecated playback speed setup method used #26

bryanlandia opened this issue Jul 24, 2018 · 1 comment

Comments

@bryanlandia
Copy link
Contributor

Putting the data attribute on the <video> tag is deprecated by BrightCove

data-setup="{"playbackRates": [0.5, 1.0, 1.5, 2.0] }”

Should be replaced with something like

videojs.registerPlugin('VSP', function () { var player = this; addPlaybackButton = function () { var playbackRateMenuButton = new videojs.getComponent('PlaybackRateMenuButton'); var oldPlaybackRateMenuButton = player.controlBar.playbackRateMenuButton; var playbackRates = new playbackRateMenuButton(player, { playbackRates: [0.5, 1, 1.5, 2] }); player.controlBar.addChild(playbackRates); player.controlBar.el().insertBefore(playbackRates.el, oldPlaybackRateMenuButton.el); player.controlBar.removeChild(oldPlaybackRateMenuButton); }; player.on("ready", function() { addPlaybackButton(); }); });
@bryanlandia
Copy link
Contributor Author

This may actually not be a valid Issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant