Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation key suggestion will be incorrect if the key is in snake_case #1114

Closed
loukhin opened this issue Jul 18, 2023 · 1 comment · Fixed by #1119
Closed

Translation key suggestion will be incorrect if the key is in snake_case #1114

loukhin opened this issue Jul 18, 2023 · 1 comment · Fixed by #1119

Comments

@loukhin
Copy link
Contributor

loukhin commented Jul 18, 2023

What version of this package are you using?
2.5.0

What operating system, Node.js, and npm version?
macOS 14.0 (Sonoma preview)
Node.JS v18.10.0

What happened?
If the translation key was in snake case, for example HELLO_WORLD
image
then the suggested translation key will be HELLO, which is incorrect
image

What did you expect to happen?
the suggested translation key showing HELLO_WORLD
image

Are you willing to submit a pull request to fix this bug?
I can try

possible fix is changing _${infer Num} to _${number}

@aralroca
Copy link
Owner

Good catch. Thanks to report It! Feel free to PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants