Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and test adni_fmap.py #1174

Closed
3 tasks done
NicolasGensollen opened this issue May 7, 2024 · 2 comments
Closed
3 tasks done

Refactor and test adni_fmap.py #1174

NicolasGensollen opened this issue May 7, 2024 · 2 comments
Assignees
Milestone

Comments

@NicolasGensollen
Copy link
Member

NicolasGensollen commented May 7, 2024

Following PR #1119 there is some cleaning and refactoring to be done around adni_fmap.py.

More precisely, we need to do:

  • Add non regression test (requires adding fmap data to CI dataset and making sure that the results are consistent)
  • Add unit tests
  • Refactor portions of the code that are difficult to understand
Copy link

github-actions bot commented Sep 2, 2024

This issue is considered stale because it has not received further activity for the last 14 days. You may remove the inactive label or add a comment, otherwise it will be closed after the next 14 days.

@github-actions github-actions bot added the inactive Issue or request has gone stale label Sep 2, 2024
@NicolasGensollen NicolasGensollen removed the inactive Issue or request has gone stale label Sep 2, 2024
@NicolasGensollen
Copy link
Member Author

Closing this as refactoring has been done, non regression tests have been added, and adding unit tests will be pursued as a continuous effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants