You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the options section the agent option is described like this: agent: null, // (/!\ only works when useElectronNet is false) Node HTTP Agent.,
If we know upfront that this option is not supported with useElectronNet enabled maybe there should be a check for that?
Like this the user gets direct feedback when using the wrong option combination and would avoid problems when e.g. switching from node-fetch to electron-fetch in which case it's easy to miss that information and the agent option is just silently ignored.
What do you think?
The text was updated successfully, but these errors were encountered:
This would be a breaking change, and in my opinion is not big enough to warrant a major version bump. I will keep this in mind for when I have enough changes to publish a major version.
In the options section the
agent
option is described like this:agent: null, // (/!\ only works when useElectronNet is false) Node HTTP Agent.,
If we know upfront that this option is not supported with
useElectronNet
enabled maybe there should be a check for that?Like this the user gets direct feedback when using the wrong option combination and would avoid problems when e.g. switching from
node-fetch
toelectron-fetch
in which case it's easy to miss that information and the agent option is just silently ignored.What do you think?
The text was updated successfully, but these errors were encountered: