Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent option silently ignored when useElectronNet is enabled #34

Open
sliminas opened this issue Apr 22, 2021 · 1 comment
Open

Agent option silently ignored when useElectronNet is enabled #34

sliminas opened this issue Apr 22, 2021 · 1 comment

Comments

@sliminas
Copy link

sliminas commented Apr 22, 2021

In the options section the agent option is described like this:
agent: null, // (/!\ only works when useElectronNet is false) Node HTTP Agent.,

If we know upfront that this option is not supported with useElectronNet enabled maybe there should be a check for that?
Like this the user gets direct feedback when using the wrong option combination and would avoid problems when e.g. switching from node-fetch to electron-fetch in which case it's easy to miss that information and the agent option is just silently ignored.

What do you think?

@arantes555
Copy link
Owner

Thank you for the PR !

This would be a breaking change, and in my opinion is not big enough to warrant a major version bump. I will keep this in mind for when I have enough changes to publish a major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants