How to use the user-provided message?

[stephenemerson85]

I watched Nick Chapsas tutorial on GuardClauses and I think it's a really neat package that helps make the code more readable and control exceptions.

One issue I'm trying to work out is how I would use the supplied-message within the catch? Normally I would just do something like ex.Message and my understanding is that it's setting the Message, but when doing this I am getting the generic Message and Input value rather than my own that i typed in.

Example
Guard.Against.NullOrWhiteSpace(FirstName, nameof(FirstName), "You must provide a first name");

When i deliberately cause the exception to throw, this is the Message that comes though.
Required input FirstName was empty. Parameter name: FirstName

[ardalis]

Seems like you may have discovered a bug.

Here is the only unit test for that overload of that method:

https://github.com/ardalis/GuardClauses/blob/main/test/GuardClauses.UnitTests/GuardAgainstNullOrWhiteSpace.cs#L53-L62

[Theory]
[InlineData(null, "Required input parameterName was empty.")]
[InlineData("Value is empty", "Value is empty")]
public void ErrorMessageMatchesExpected(string customMessage, string expectedMessage)
{
    var exception = Assert.Throws<ArgumentException>(() => Guard.Against.NullOrWhiteSpace(" ", "parameterName", customMessage));
    Assert.NotNull(exception);
    Assert.NotNull(exception.Message);
    Assert.Equal(expectedMessage + " (Parameter 'parameterName')", exception.Message);
}

The second test seems to show that the customMessage should show up followed by " (Parameter 'parametername')". That's not what you're seeing?