-
-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@graphql-tools/mock v8.7.2 introduces breaking changes via @graphql-tools/scheam v9 upgrade #4642
Comments
Sorry for inconvenience but I couldn't reproduce the issue here. |
Actually after thinking about it I even think the @graphql-tools/[email protected] should be a v9 as it removed a function without bumping a major version. |
But first we need to revert it as a patch release then release a major. |
@ardatan Yes exactly adding the function to schema isn't breaking but removing it from merge would be indeed |
Happy to help if I can. |
For the next time, I'd appreciate if you can share a reproduction on CodeSandbox or StackBlitz. Other than that, creating this issue is really helpful for me to realize my mistake :) |
Sure thing hard to reproduce easily as it kinda depends whether npm/node will want to load one version or the other anyway but noted for next time ;) Thank you for the reactivity 🎉 |
Could you confirm it's been fixed? |
I can confirm this was fixed with the new patch release |
Issue workflow progress
Progress of the issue based on the Contributor Workflow
Describe the bug
When using @graphql-toosl/mock ^8.0.0 & @graphql-tools/schema ^8.0.0. at the same time, an incompatibility appeared with @graphql-tools/merge where extractExtensionsFromSchema moved from one package to the other. The two versions of the
/merge
dependencies are installed and unless with yes yarn resolutions we can't fix it.Those packages being quite coupled we often use them together.
Unless a quick patch is done we will migrate
/schema
to v9 to fix this on our side.To Reproduce
Steps to reproduce the behavior:
Expected behavior
The v8.7.2 of
/mock
could keep targeting a v8 of/schema
and a v9 of the/mock
lib could be released to avoid breaking changes.Environment:
@graphql-tools/...
:Additional context
We are encountering this issue in Strapi here strapi/strapi#14048.
The text was updated successfully, but these errors were encountered: