Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip IOPORT_CFG_PMOS to _NMOS as needed #358

Closed
wants to merge 21 commits into from
Closed

Flip IOPORT_CFG_PMOS to _NMOS as needed #358

wants to merge 21 commits into from

Conversation

rowingdude
Copy link

Add a conditional statement to check if we're on an Uno, this flips IOPORT_CFG_PMOS to _NMOS as needed.

@rowingdude
Update digital.cpp
d99e561 
Add a conditional statement to check if we're on an Uno, this flips IOPORT_CFG_PMOS to _NMOS as needed.
@rowingdude
Merge branch 'main' into main
d2f0a9c
@rowingdude
Update RTC.cpp
6f331bd 
Add a condition to ensure we're within the 2000-2099 year range.
@rowingdude
Update RTC.cpp
20319d8 
Adds a check to RTCTime::setUnixTime(time_t time) to make sure we're in a valid year range (2000-2099)
@rowingdude
Copy link
Author

Per issue #321, I have also edited the RTC.cpp file with two if-statements in setYear and setUnixTime to ensure the date range is valid per the RTC manufacturer's guidelines (year 2000 to 2099).

@rowingdude
Copy link
Author

The initial commit (digital.cpp) is to address issue #343

@rowingdude
Update WiFiTypes.h
405e04b 
Per issue #294, imported the header definitions from wl_definitions.h
@rowingdude
Copy link
Author

Per issue #294 I integrated the wl_definitions.h #defines with the new wifiTypes.h header file.

@rowingdude
Copy link
Author

There seem to be some errors in the original syntax of the rtc.cpp file. I will investigate them.

@rowingdude
Update RTC.cpp
4d6cd7b 
Fix forgotten closing brace
@per1234 per1234 linked an issue Aug 7, 2024 that may be closed by this pull request
[Uno R4 minima] GPIO open drain mode select bug #343
Open
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Aug 7, 2024
@rowingdude
Update RTC.cpp
a7cb79c 
Remove unnecessary `RTClock::` in an effort to get rid of the *qualified-id in declaration before* compiler warnings.
@rowingdude
Copy link
Author

I have attempted to address the "qualified-id in declaration" which is done by removing the RTClock:: in bool RTClock::isSet() so it's just bool isSet() { ... }.

@rowingdude
Update RTC.h
6d5f3c8 
Revising the class definition for RTClock to both inline some items and trace down compiler warnings.
@rowingdude
Update RTC.h
e134df5 
Roll back due to incompatibility.
@rowingdude
Update RTC.cpp
36e46b0 
Rollback - keeping domain qualifiers for now.
@rowingdude
Copy link
Author

I have rolled back the changes due to more breakage in the Portenta, Minima, and UnoR4Wifi codebases. I'll look into why those are occuring. The PR is now versioned at my 4d6cd7 commit.

@rowingdude rowingdude closed this Aug 12, 2024
@per1234 per1234 changed the title Update digital.cpp Flip IOPORT_CFG_PMOS to _NMOS as needed Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uno R4 minima] GPIO open drain mode select bug
2 participants
@rowingdude @per1234