Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent parsing CLI errors without metadata #2518

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: prevent parsing CLI errors without metadata #2518

merged 1 commit into from
Oct 22, 2024

Conversation

giacomocusinato
Copy link
Collaborator

@giacomocusinato giacomocusinato commented Sep 26, 2024 •
edited
Loading

Motivation

Fixes #2516

Change description

Prevent parsing metadata from CLI errors when no metadata items present.

Minor changes:

  • Use getTypeName instead of getTypeUrl to parse grpc error
  • Add type assertion to isInstanceOf function

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@giacomocusinato
fix: prevent parsing CLI errors without metadata
409dd5c 
When parsing a CLI error, check if any metadata from grpc is present before trying to parse it.
Closes #2516
@giacomocusinato giacomocusinato added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 26, 2024
@giacomocusinato giacomocusinato self-assigned this Sep 27, 2024
per1234
per1234 approved these changes Oct 6, 2024
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @giacomocusinato!

@per1234 per1234 merged commit 4a3abf5 into main Oct 22, 2024
42 checks passed
@per1234 per1234 deleted the #2516 branch October 22, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees

@giacomocusinato giacomocusinato

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload indicated as successful even when it failed
2 participants
@giacomocusinato @per1234