Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote sketchbook is limited to 20 sketches #809

Closed
fstasi opened this issue Feb 4, 2022 · 0 comments · Fixed by #875
Closed

Remote sketchbook is limited to 20 sketches #809

fstasi opened this issue Feb 4, 2022 · 0 comments · Fixed by #875
Assignees
Labels
conclusion: resolved Issue was resolved criticality: high Of high impact phase: implementation Work is in the implementation phase topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@fstasi
Copy link
Contributor

fstasi commented Feb 4, 2022

Arduino IDE2 has the capability to fetch the sketches from the arduino create API.

During the initialization phase the following function gets called:
const sketches = await this.createApi.sketches();

We noticed that create-api has a pagination implemented that limits result to 120 result per page, we need to enable fetching with pagination.

To do so, the sketches() method implementation need to handle the pagination and return the result once all the sketches are correctly fetched from the endpoint

@fstasi fstasi added criticality: high Of high impact phase: implementation Work is in the implementation phase type: imperfection Perceived defect in any part of project labels Feb 4, 2022
@fstasi fstasi added this to the arduino-ide rc5 milestone Feb 4, 2022
@fstasi fstasi assigned fstasi and unassigned AlbyIanna Feb 4, 2022
@per1234 per1234 added the topic: code Related to content of the project itself label Feb 4, 2022
@per1234 per1234 changed the title remote sketchbook limit to 20 sketches Remote sketchbook is limited to 20 sketches Feb 4, 2022
@per1234 per1234 linked a pull request Feb 28, 2022 that will close this issue
4 tasks
@per1234 per1234 added the conclusion: resolved Issue was resolved label Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved criticality: high Of high impact phase: implementation Work is in the implementation phase topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants