Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting latest nvd3 and d3 versions #59

Open
iyerramji opened this issue Sep 3, 2015 · 4 comments
Open

Supporting latest nvd3 and d3 versions #59

iyerramji opened this issue Sep 3, 2015 · 4 comments

Comments

@iyerramji
Copy link

Hi,
I see some issues with the tooltip of a linewithfocuscharts charts that are generated when I use several parameters on the y-axis.

Maybe these are automatically solved when you support latest version of nvd3 and d3 ?

Is there a plan to migrate to those ?

@areski
Copy link
Owner

areski commented Sep 3, 2015

It should be better to open this issue on https://github.com/areski/python-nvd3

Ideally we would support recent version of nvd3 (at this moment 1.8.1) but we could use more help, you are more than welcome to give us a hand :)

@goetzb
Copy link

goetzb commented Dec 29, 2016

@areski Do you have any update on the status? I ran into some label positioning issues in bar charts with the current NVD3 versions that are supported - my charts work much better with newer D3.js and NVD3 versions, but as other bits were broken when using django-nvd3 I kept the older versions in production.

In https://github.com/novus/nvd3/blob/master/README.md a range of new chart types are listed in the changes in the 1.8 series of releases, which might also be worth adding. I will see if I can perhaps contribute something myself to update python-nvd3 and/or django-nvd3...

@areski
Copy link
Owner

areski commented Dec 30, 2016

The big part of the job is to update python-nvd3 to support nvd3-v1.8, there is a branch started for it (https://github.com/areski/python-nvd3/tree/nvd3-1.8) but no much work has been done so far, we could use help. Well we need help :)

@goetzb
Copy link

goetzb commented Dec 11, 2020

Somewhat related to this existing issue: Is there any reason why python-nvd3==0.15.0 isn't supported yet? I've been pinning my dependencies to django-nvd3==0.9.7 and python-nvd3==0.15.0 for a while now without problems, but with the new pip resolver, this causes an error:

ERROR: Cannot install -r requirements_dev.txt (line 17) and python-nvd3==0.15.0 because these package versions have conflicting dependencies.
The conflict is caused by:
    The user requested python-nvd3==0.15.0
    django-nvd3 0.9.7 depends on python-nvd3==0.14.2
To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies

(See Python Software Foundation Blog: New pip resolver to roll out this year from March 2020 for general information about this change.)

I would suggest a simple update to the requirements.txt that allows at least 0.15.0 as well as older versions. This change has already been made in the develop branch (https://github.com/areski/django-nvd3/blob/develop/requirements.txt, see also 639300a), it just needs to be included in a new release.

A short term fix is also mentioned in Python Software Foundation Blog: Releasing pip 20.3, featuring new dependency resolver from November 2020 which works for me, but it might stop working after January 2021 in pip 21.0:

pip install -r requirements_dev.txt --use-deprecated=legacy-resolver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants