Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ModuleNotFoundError and ImportError when importing argilla.feedback.* #3468

Closed
gabrielmbmb opened this issue Jul 27, 2023 · 1 comment
Assignees
Labels
type: bug Indicates an unexpected problem or unintended behavior

Comments

@gabrielmbmb
Copy link
Member

gabrielmbmb commented Jul 27, 2023

Describe the bug
When trying to use import something from argilla.feedback module a ModuleNotFoundError is raised because fastapi is not installed and an ImportError because pyyaml is not installed either.

Stacktrace and Code to create the bug

pip install argilla==1.13.2
from argilla.feedback import SuggestionSchema

Expected behavior
I can import stuff from argilla.feedback module without getting a ModuleNotFoundError and without installing fastapi and PyYAML dependencies which should be only needed for the server and extra integrations.

Environment:

  • Argilla Version [e.g. 1.0.0]: 1.13.2
  • ElasticSearch Version [e.g. 7.10.2]: 8.5.3
  • Docker Image (optional) [e.g. argilla:v1.0.0]: Not relevant

Additional context
The bug was introduced in #3336, when the telemetry used in the server (it imports fastapi) was added to the Argilla Trainer.

@gabrielmbmb gabrielmbmb added type: bug Indicates an unexpected problem or unintended behavior client labels Jul 27, 2023
@alvarobartt
Copy link
Member

Additionally, we should refactor argilla.feedback to either be replaced with the whole content of argilla.client.feedback or to be removed, as it's confusing to have both and one just being a replica with the imports from the other.

@gabrielmbmb gabrielmbmb changed the title [BUG] No module named fastapi when importing argilla.feedback.* [BUG] ModuleNotFoundError and ImportError when importing argilla.feedback.* Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants