Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

Bug: Resending notification when one trigger has failed #115

Closed
olegsu opened this issue Sep 17, 2020 · 1 comment
Closed

Bug: Resending notification when one trigger has failed #115

olegsu opened this issue Sep 17, 2020 · 1 comment

Comments

@olegsu
Copy link
Contributor

olegsu commented Sep 17, 2020

I have created the following argocd-notifications-cm with subscriptions:

      subscriptions:
        - recipients:
          - slack:some-channel
          trigger: custom-trigger

Then I've added another recipient: - email:[email protected], the notifier YAML is not updated, yet.
As a result, the controller keeps sending the slack notification because the SMTP was not configured yet.
I think it is because of the missing annotation that the controller adds to the application.
A fix can be either to add the annotation, logging the fact that not all the notifications have been sent. Or, to create annotation per recipient.

@olegsu
Copy link
Contributor Author

olegsu commented Sep 17, 2020

Duplicate: #79

@olegsu olegsu closed this as completed Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant