Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target_revision label to the argocd_app_info metric #16469

Closed
reegnz opened this issue Nov 28, 2023 · 3 comments
Closed

Add target_revision label to the argocd_app_info metric #16469

reegnz opened this issue Nov 28, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@reegnz
Copy link
Contributor

reegnz commented Nov 28, 2023

Summary

We want to monitor argocd projects, and identify what branches an application is refering to.

Motivation

Sometimes app configuration becomes outdated and refers to branches that don't exist anymore (eg. development branches that have been merged).

We would like to corellate argocd applications with git metadata and identify misconfiguration issues through metrics.

Proposal

Add a new label target_revision to the argocd_app_info time series, so it's also exposed as a metric.
This new label shouldn't cause significant cardinality changes.

@reegnz reegnz added the enhancement New feature or request label Nov 28, 2023
@evankanderson
Copy link

This would be useful for me as well. Is someone working on this yet? Would a PR be accepted?

@ebuildy
Copy link
Contributor

ebuildy commented Jan 7, 2024

duplicate of #4115 - fixed by #15143

@reegnz
Copy link
Contributor Author

reegnz commented Jan 9, 2024

Closing as duplicate, thanks for noticing!

@reegnz reegnz closed this as completed Jan 9, 2024
@reegnz reegnz reopened this Jan 9, 2024
@reegnz reegnz closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants