Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metrics] git ls-remote failure counter #17956

Closed
ebuildy opened this issue Apr 24, 2024 · 3 comments · Fixed by #18250
Closed

[metrics] git ls-remote failure counter #17956

ebuildy opened this issue Apr 24, 2024 · 3 comments · Fixed by #18250
Assignees
@Jack-R-lantern
Labels
enhancement New feature or request

Comments

@ebuildy
Copy link
Contributor

ebuildy commented Apr 24, 2024

Summary

Relate to #15658, be able to monitor if git ls-remote fail, use case: if git branch dont exist any more.

Motivation

We would like to be able to detect wrong app config, wrong git branch.

Proposal

As the good job done at #15657, I propose a new metric argocd_git_lsremote_fail_total or a new label status for existing metric argocd_git_request_total.
@ebuildy ebuildy added the enhancement New feature or request label Apr 24, 2024
@Jack-R-lantern
Copy link
Contributor

Please assign me

@Jack-R-lantern
Copy link
Contributor

@ebuildy
#15657 (comment)

Oh, I noticed your mention.
Is it okay if I implement that issue?

@ebuildy
Copy link
Contributor Author

ebuildy commented May 16, 2024

@ebuildy #15657 (comment)

Oh, I noticed your mention. Is it okay if I implement that issue?

hey @Jack-R-lantern go for it! didnt spend time on it. Thanks you

@Jack-R-lantern Jack-R-lantern mentioned this issue May 16, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jack-R-lantern Jack-R-lantern

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(metric): add ls-remote request fail metric(#17956) Jack-R-lantern/argo-cd
2 participants
@ebuildy @Jack-R-lantern