feat: Add autocomplete for repo Revisions (#4645) #4713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetchel
force-pushed
the
autocompleteRefs
branch
from
0b7c8c1
to
fbfacf2
Compare
tetchel
changed the title
- Introduces api/v1/repositories/{repo}/refs which returns branches and tags
- Add new RevisionFormField component to Create and Edit Application pages
Signed-off-by: Tim Etchells <[email protected]>
tetchel
force-pushed
the
autocompleteRefs
branch
from
fbfacf2
to
7596701
Compare
alexmt
requested changes
Oct 31, 2020
util/git/git_test.go
Outdated
| assert.NotContains(t, lsResult.Branches, testTag) | ||
| assert.NotContains(t, lsResult.Tags, testBranch) | ||
|
|
||
| //fmt.Printf("BRANCHES: %s\n", strings.Join(lsResult.Branches, ", ")) |
There was a problem hiding this comment.
Please remove commented code.
| load={async (src: any): Promise<string[]> => { | ||
| if (src.repoURL) { | ||
| try { | ||
| const revisionsRes = await services.repos.revisions(src.repoURL); |
There was a problem hiding this comment.
I think it would be easy to read if we don't use async. E.g.
return services.repos.revisions(src.repoURL).
then(revisionsRes =>[ 'HEAD' ].concat(revisionsRes.branches).concat(revisionsRes.tags) ).
catch(() => []);What do you think?
There was a problem hiding this comment.
Sure, doesn't matter to me
reposerver/repository/repository.go
Outdated
| s.metricsServer.IncPendingRepoRequest(q.Repo.Repo) | ||
| defer s.metricsServer.DecPendingRepoRequest(q.Repo.Repo) | ||
|
|
||
| // TODO is locking necessary here? We are not modifying the repository, just running an ls-remote |
There was a problem hiding this comment.
Locking is not required ( it is necessary only if we are touching local repo files). Please remove comment
reposerver/repository/repository.go
Outdated
| return nil, err | ||
| } | ||
|
|
||
| // TODO check cache |
There was a problem hiding this comment.
The ls-remote is used if every other repo server operation without caching. In fact it is used to find cache key. So I think caching is not required here and we can remove this comment.
Signed-off-by: Tim Etchells <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4713 +/- ##
==========================================
+ Coverage 41.10% 41.13% +0.03%
==========================================
Files 127 127
Lines 17367 17548 +181
==========================================
+ Hits 7139 7219 +80
- Misses 9202 9298 +96
- Partials 1026 1031 +5 ☔ View full report in Codecov by Sentry. |
terrycorley
pushed a commit
to terrycorley/argo-cd
that referenced
this pull request
Nov 3, 2020
…zation-generators * 'master' of github.com:argoproj/argo-cd: fix: RevisionFormField component crashes in 'refs' API returns no tags (argoproj#4735) docs: add Opensurvey to USERS.md (argoproj#4727) docs: correct parameters usage in CLI (argoproj#4725) fix: Repo-server has silent unmarshalling errors leading to empty applications (argoproj#4423) (argoproj#4708) fix: inject artificial delay between sync waves to better support health assessments (argoproj#4715) fix: exclude files listed under exclusions (argoproj#4686) feat: support resource actions on CRDs that use status subresources (argoproj#4690) feat: Add autocomplete for repo Revisions (argoproj#4645) (argoproj#4713) fix: webhook don't refresh apps pointing to HEAD (argoproj#4717) feat: Add support for ExecProvider cluster auth (argoproj#4600) (argoproj#4710) fix: adding helm values file in New App (argoproj#4635) docs: Instructions on `make verify-kube-connect` step when using k3d (argoproj#4687) feat: Annotation based app paths detection in webhooks (argoproj#4699) fix: adding commonAnnotations for Kustomize (argoproj#4613)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tim Etchells [email protected]
Checklist:
Resolves #4645
See issue for screenshots