Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update entrypoints after argo pr 12707 #1883

Closed
gczuczy opened this issue Mar 3, 2023 · 1 comment
Closed

Update entrypoints after argo pr 12707 #1883

gczuczy opened this issue Mar 3, 2023 · 1 comment
Labels
argo-cd awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. enhancement New feature or request

Comments

@gczuczy
Copy link
Contributor

gczuczy commented Mar 3, 2023

Is your feature request related to a problem?

The entrypoint change in argoproj/argo-cd#12707 is another step for making a distroless image possible.
Currently the argocd helm chart does not make it possible to remove the entrypoint.sh from the manifests for using tini directly instead.

Once the PR is merged, entrypoint.sh can be removed from the manifests, and all services started directly with args. Please see the first comment in the PR for details and kubernetes docs on the topic.

Related helm chart

argo-cd

Describe the solution you'd like

Removing the dependency on any kind of shell, so there's one less blocker for a distroless image.

Describe alternatives you've considered

I'm not sure there are a lot of alternatives, tini is pretty much accepted as the de-facto standard for container entrypoints.

Additional context

No response

@gczuczy gczuczy added the enhancement New feature or request label Mar 3, 2023
@pdrastil pdrastil added argo-cd awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. labels Mar 3, 2023
@yu-croco
Copy link
Collaborator

yu-croco commented Apr 9, 2023

This issue seems resolved.

@yu-croco yu-croco closed this as completed Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants