Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronization and updating of Kubernetes ingresses in different namespaces. #2101

Closed
hpmistry19 opened this issue Jun 9, 2023 · 4 comments · Fixed by #2207
Closed

Synchronization and updating of Kubernetes ingresses in different namespaces. #2101

hpmistry19 opened this issue Jun 9, 2023 · 4 comments · Fixed by #2207
Labels
argo-rollouts bug Something isn't working

Comments

@hpmistry19
Copy link

Describe the bug

We encountered an intriguing error/bug that reveals a permission-related issue. The error message highlights that the user "system:serviceaccount:argo-rollouts:argo-rollouts" lacks the necessary privileges to update the "ingresses" resource within the "networking.k8s.io" API group across the specified namespace(s) "*".

Upon investigating the issue, it appears that the reference at https://github.com/argoproj/argo-helm/blob/main/charts/argo-rollouts/templates/controller/clusterrole.yaml indicates that the "ingress" resource lacks the capability to perform "update" operations on resources.

During my attempts to modify the existing clusterrole permission, specifically to allow the "update" verb for the "ingress" resource, I encountered limitations preventing me from making the desired changes. In light of this, I kindly request the assistance of someone knowledgeable in this matter to review the situation and provide guidance on resolving the issue.

Related helm chart

argo-rollouts

Helm chart version

2.22.2

To Reproduce

  1. Described the clusterrole having this issue.
  2. Tried to edit the clusterrole to add verbs "update"
  3. Tried to patch the existing clusterrole to add verb "update"

Expected behavior

It is expected that the "argo-rollout" clusterrole grants permissions to update the "ingresses" resource within the "networking.k8s.io" API group across the specified namespaces.

Screenshots

No response

Additional context

No response

@hpmistry19 hpmistry19 added the bug Something isn't working label Jun 9, 2023
@yu-croco
Copy link
Collaborator

argo-rollouts follows the upstream's manifest, so I wonder it's better to fix the upstream at first. 🤔

@hpmistry19
Copy link
Author

I am unsure if we are allowed to edit the main upstream chart here?

@yu-croco
Copy link
Collaborator

@hpmistry19
If there is a reasonable reason, anybody can submit PR. 👍

@zachaller
Copy link

This has been changed upstream argoproj/argo-rollouts#2933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-rollouts bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants