Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact Repository for Azure Blob - values/examples not reflecting AzureArtifiactRepository blobNameFormat #2200

Closed
jsong336 opened this issue Aug 3, 2023 · 0 comments · Fixed by #2229
Labels
argo-workflows bug Something isn't working

Comments

@jsong336
Copy link
Contributor

jsong336 commented Aug 3, 2023

Describe the bug

Values and examples in the document for using Azure Blob artifact repository does not reflect AzureArtifiactRepository. Following the document/examples leads to following error in the argo workflow controller: Failed to register watch for controller config map: error unmarshaling JSON: while decoding JSON: json: unknown field \"blob\ in the workflow controller

...
artifactRepository:
  azure:
    endpoint: https://myblob.blob.core.windows.net
    container: mycontainer
    blob: myblob # this should be blobNameFormat
    accountKeySecret:
      name: my-azure-storage-credentials
      key: my-account-access-key

This started happening after upgrading to 0.32.1 but was in several version behind before upgrading. I am assuming this might have started complaining after https://github.com/argoproj/argo-workflows/blob/master/docs/upgrading.md#feat-fail-on-invalid-config-8295

Passing in blobNameFormat instead of blob seems to work

Related helm chart

argo-workflows

Helm chart version

0.32.1

To Reproduce

Install Argo Workflow with Chart 0.32.1 and use azure artifactRepository with blob key

artifactRepository:
  azure:
    endpoint: https://myblob.blob.core.windows.net
    container: mycontainer
    blob: myblob # this should be blobNameFormat
    accountKeySecret:
      name: my-azure-storage-credentials
      key: my-account-access-key

Expected behavior

This is probably expected behavior but will requires update in document

Screenshots

No response

Additional context

No response

@jsong336 jsong336 added the bug Something isn't working label Aug 3, 2023
@jsong336 jsong336 changed the title Argo Workflow not reflecting AzureArtifiactRepository blobNameFormat Artifact Repository for Azure Blob - values/examples not reflecting AzureArtifiactRepository blobNameFormat Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-workflows bug Something isn't working
Projects
None yet
2 participants