Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lifecycle hooks for Argo Workflows Server #2996

Open
BojanZelic opened this issue Oct 28, 2024 · 0 comments · May be fixed by #2997
Open

Support lifecycle hooks for Argo Workflows Server #2996

BojanZelic opened this issue Oct 28, 2024 · 0 comments · May be fixed by #2997
Labels
argo-workflows enhancement New feature or request

Comments

@BojanZelic
Copy link

Is your feature request related to a problem?

Whenever argo workflows server pods are rollout-restarted, evicted, ect a small blip of downtime occurs when using AWS ALB ingress resource to expose argo workflows (but probably true with any load balancer)

Related helm chart

argo-workflows

Describe the solution you'd like

expose configurations of lifecycle param to set a preStop hook, and a configuration for terminationGracePeriodSeconds to allow pods to persist any remaining connections

Describe alternatives you've considered

No response

Additional context

ex:

#values.yaml
  server:
   lifecycle:
     preStop: 
       exec:
         command:
           - /bin/sh
           - -c
           - |
             sleep 60;

    terminationGracePeriodSeconds: 65

would allow it to have enough time to remove the IP from AWS ALB, ensuring no-downtime deployments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-workflows enhancement New feature or request
Projects
None yet
2 participants