Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to add annotations to AnalysisRuns that are created from Templates #1282

Closed
btlyken opened this issue Jun 16, 2021 · 4 comments
Closed
Labels
enhancement New feature or request no-issue-activity

Comments

@btlyken
Copy link

btlyken commented Jun 16, 2021

Summary

As someone who wants to use ClusterAnalysisTemplates to test our deployed microservices during and after a canary deployment, it would be useful to be able to add annotations to the AnalysisRuns that get created from these templates. Instead of using a template, we have to create individual runs for each microservice we're testing with the annotations we want.

Use Cases

My main use case in mind is to be able to add a helm.sh/hook: test annotation so that we can use helm test to use these AnalysisRuns to validate the deployed microservices are functioning correctly. We'd also like to include add a helm.sh/hook-delete-policy annotation to clean up these runs during the next deployment or after the run succeeds.

Two ways I could see implementing this would be:

  • For the AnalysisRun to inherit the annotations of the template resource
    • One potential issue with this route is that it would inherit Helm deployment annotations and labels which may not match the microservice's Helm deployment info
  • For there to be a metadata section, such as spec.template.metadata, that would support adding annotations and labels to these runs

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@btlyken btlyken added the enhancement New feature or request label Jun 16, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

This issue is stale because it has been open 60 days with no activity.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2023

This issue is stale because it has been open 60 days with no activity.

@shaoye
Copy link

shaoye commented May 13, 2023

this should be fixed by #2743 soon

@zachaller
Copy link
Collaborator

fixed by #2743, thanks for linking them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Development

No branches or pull requests

3 participants