Experiment service names too long for DNS conventions

[khhirani]

Message: RolloutAborted: Rollout aborted update to revision 2: Failed to create Service for template 'experiment-alb-canary-very-long-name-xxxxxxxxxxxx': Service "rollouts-demo-5c455b5b8c-2-0-experiment-alb-canary-very-long-name-xxxxxxxxxxxx" is invalid: metadata.name: Invalid value: "rollouts-demo-5c455b5b8c-2-0-experiment-alb-canary-very-long-name-xxxxxxxxxxxx": must be no more than 63 characters

Services cannot be created with names longer than 63 characters. This is a problem when we create a service for an Experiment step in Canary with Traffic Routing, since we use the ReplicaSet name as the service name. We need to enforce that all services we create are 63 characters or less.

The problematic code is here:

https://github.com/argoproj/argo-rollouts/blob/master/experiments/experiment.go#L287-L290

[github-actions]

This issue is stale because it has been open 60 days with no activity.

[Lykathia]

Also have run into this. Wasn't an issue on 1.3 that we saw, but is now an issue on 1.4

[fwippe]

For the record: the behavior of always creating an experiment service was indeed introduced with v1.4. See PR #2397.

Just created bug ticket #2622.

[github-actions]

This issue is stale because it has been open 60 days with no activity.