Argo Rollout Notifications docs is not correct

[faustodavid]

Summary

What happened/what you expected to happen?

I was trying to follow the docs https://argoproj.github.io/argo-rollouts/generated/notification-services/webhook/ but failed to implement it.

In the end, I managed to implement the notification webhook with the help of @jessesuen which points me out the following.

• The docs mention "Register webhook in argocd-notifications-cm ConfigMap" but it actually should be in argo-rollouts-notification-configmap in order to have access to the pre-defined argo-rollouts triggers.
• It is required to create the secret argo-rollouts-notification-secret even if your webhook does not require any secret.

Diagnostics

What version of Argo Rollouts are you running?
1.1.0

# Paste the logs from the rollout controller

# Logs for the entire controller:
kubectl logs -n argo-rollouts deployment/argo-rollouts

# Logs for a specific rollout:
kubectl logs -n argo-rollouts deployment/argo-rollouts | grep rollout=<ROLLOUTNAME>

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

[Nishant-sehgal]

I can pick this up. Can you assign this to me ?

[Nishant-sehgal]

Have created a PR for this: argoproj/notifications-engine#113

[Nishant-sehgal]

@zachaller can u check ?