-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Notification services docs #1680
Comments
To help anyone coming later - the bulk of the notif docs seem to be pulled in: https://github.com/argoproj/argo-rollouts/blob/master/hack/gen-docs/main.go#L28 |
Docs should give guidance to the namespace that the |
This issue is stale because it has been open 60 days with no activity. |
I was looking at this in my PR #3384 but its hard to keep up to date with changes in the docs if they are specific to ArgoCD, I would prefer if the notifications-engine docs were project agnostic and each project would make their replacements Although a string replacement is simple, entire examples may not be... |
Summary
Argo Rollout Notification services documentation uses app in the templates instead of rollouts as it might have been taken from argocd-notifications documentation.
https://argoproj.github.io/argo-rollouts/generated/notification-services/email/
It would be good to update it with rollout templates in all the services documentaitons.
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
The text was updated successfully, but these errors were encountered: