Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Notification services docs #1680

Open
RaviHari opened this issue Dec 2, 2021 · 4 comments
Open

Update Notification services docs #1680

RaviHari opened this issue Dec 2, 2021 · 4 comments
Labels
bug Something isn't working docs Needs documentation/release notes no-issue-activity

Comments

@RaviHari
Copy link
Contributor

RaviHari commented Dec 2, 2021

Summary

Argo Rollout Notification services documentation uses app in the templates instead of rollouts as it might have been taken from argocd-notifications documentation.
https://argoproj.github.io/argo-rollouts/generated/notification-services/email/
It would be good to update it with rollout templates in all the services documentaitons.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@RaviHari RaviHari added the bug Something isn't working label Dec 2, 2021
@harikrongali harikrongali added this to the v1.4 milestone Oct 20, 2022
@meeech
Copy link
Contributor

meeech commented Nov 29, 2022

To help anyone coming later - the bulk of the notif docs seem to be pulled in: https://github.com/argoproj/argo-rollouts/blob/master/hack/gen-docs/main.go#L28

@meeech
Copy link
Contributor

meeech commented Nov 29, 2022

Docs should give guidance to the namespace that the notifications-install.yaml should be installed to: same namespace as the controller

@zachaller zachaller removed this from the v1.4 milestone Dec 1, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@kzap
Copy link
Contributor

kzap commented Feb 21, 2024

I was looking at this in my PR #3384 but its hard to keep up to date with changes in the docs if they are specific to ArgoCD, I would prefer if the notifications-engine docs were project agnostic and each project would make their replacements

Although a string replacement is simple, entire examples may not be...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Needs documentation/release notes no-issue-activity
Projects
None yet
Development

No branches or pull requests

6 participants