Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the option to avoid fast-tracked rollbacks #1748

Open
bysph opened this issue Jan 6, 2022 · 4 comments
Open

Provide the option to avoid fast-tracked rollbacks #1748

bysph opened this issue Jan 6, 2022 · 4 comments
Labels
enhancement New feature or request no-issue-activity

Comments

@bysph
Copy link

bysph commented Jan 6, 2022

Summary

Currently argo rollouts performs a "fast-tracked rollback" (which skips pauses, steps, analysis) in two circumstances:
we detect if we are moving back to a blue-green ReplicaSet which exists and is still scaled up (within its scaleDownDelay)
if we are moving back to the canary's "stable" ReplicaSet and the upgrade has not yet completed.
(copy from #574)

I want to find a way to choose not to use "fast-tracked rollback" in some situations.

Use Cases

For example, an application needs to avoid multiple instances being started at the same time due to insufficient performance of the surrounding system, but sometimes we need to rollback during the canary.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@bysph bysph added the enhancement New feature or request label Jan 6, 2022
@bysph
Copy link
Author

bysph commented Jan 6, 2022

@jessesuen

@bysph bysph changed the title Is there any way to avoid fast-tracked rollbacks during canary? Is there any way to avoid fast-tracked rollbacks? Jan 6, 2022
@bysph bysph changed the title Is there any way to avoid fast-tracked rollbacks? Provide the option to to avoid fast-tracked rollbacks Jan 6, 2022
@bysph bysph changed the title Provide the option to to avoid fast-tracked rollbacks Provide the option to avoid fast-tracked rollbacks Jan 7, 2022
@jessesuen
Copy link
Member

For example, an application needs to avoid multiple instances being started at the same time due to insufficient performance of the surrounding system, but sometimes we need to rollback during the canary.

An option to avoid fast-tracked rollbacks means that we should run steps/pauses/analysis when going back. However the use case you describe doesn't seem to want that either, so I don't think executing the steps/analysis/pauses is what you want as opposed to limiting the total number of replicas when going back.

Have you tried the dynamicStableScale which balances the total replica counts according to traffic weights?

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-issue-activity
Projects
None yet
Development

No branches or pull requests

2 participants