Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: common questions for Rollbacks #2027

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

kostis-codefresh
Copy link
Member

Signed-off-by: Kostis Kapelonis [email protected]

Answering some questions for rollbacks that I see multiple people asking over and over in the Slack channels.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #2027 (20ed27d) into master (59f949c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2027   +/-   ##
=======================================
  Coverage   82.50%   82.50%           
=======================================
  Files         120      120           
  Lines       17054    17054           
=======================================
  Hits        14070    14070           
  Misses       2283     2283           
  Partials      701      701           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59f949c...20ed27d. Read the comment docs.

@pragmaticivan
Copy link

pragmaticivan commented May 11, 2022

Would you mind adding a comment about low traffic canary services to avoid inconclusive releases (and might cause a rollback) where metrics are not generated due to 0 or low traffic?

Perhaps an example with parallel smoke tests with the duration of the projected canary?

@kostis-codefresh
Copy link
Member Author

@pragmaticivan Any examples that you are interested in should go on a separate PR. That being said, if you think that the FAQ for rollbacks should be extended, I think it is best to open your own PR and discuss it there. I prefer to focus on a single thing on each PR.

@todaywasawesome todaywasawesome requested review from zachaller and removed request for huikang June 29, 2022 14:41
@zachaller zachaller added the ready-for-review Ready for final review label Sep 26, 2022
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoluz leoluz merged commit df3156a into argoproj:master Sep 26, 2022
daixijun pushed a commit to daixijun/argo-rollouts that referenced this pull request Sep 27, 2022
Signed-off-by: Kostis Kapelonis <[email protected]>

Signed-off-by: Kostis Kapelonis <[email protected]>
Signed-off-by: Xijun Dai <[email protected]>
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
Signed-off-by: Kostis Kapelonis <[email protected]>

Signed-off-by: Kostis Kapelonis <[email protected]>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
Signed-off-by: Kostis Kapelonis <[email protected]>

Signed-off-by: Kostis Kapelonis <[email protected]>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
Signed-off-by: Kostis Kapelonis <[email protected]>

Signed-off-by: Kostis Kapelonis <[email protected]>
@kostis-codefresh kostis-codefresh deleted the rollback-faq branch April 18, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants