-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: common questions for Rollbacks #2027
Conversation
Signed-off-by: Kostis Kapelonis <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #2027 +/- ##
=======================================
Coverage 82.50% 82.50%
=======================================
Files 120 120
Lines 17054 17054
=======================================
Hits 14070 14070
Misses 2283 2283
Partials 701 701 Continue to review full report at Codecov.
|
Would you mind adding a comment about Perhaps an example with parallel smoke tests with the duration of the projected canary? |
@pragmaticivan Any examples that you are interested in should go on a separate PR. That being said, if you think that the FAQ for rollbacks should be extended, I think it is best to open your own PR and discuss it there. I prefer to focus on a single thing on each PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Kostis Kapelonis <[email protected]> Signed-off-by: Kostis Kapelonis <[email protected]> Signed-off-by: Xijun Dai <[email protected]>
Signed-off-by: Kostis Kapelonis <[email protected]> Signed-off-by: Kostis Kapelonis <[email protected]>
Signed-off-by: Kostis Kapelonis <[email protected]> Signed-off-by: Kostis Kapelonis <[email protected]>
Signed-off-by: Kostis Kapelonis <[email protected]> Signed-off-by: Kostis Kapelonis <[email protected]>
Signed-off-by: Kostis Kapelonis [email protected]
Answering some questions for rollbacks that I see multiple people asking over and over in the Slack channels.
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.