Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention supported versions #2163

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

kostis-codefresh
Copy link
Member

Signed-off-by: Kostis Kapelonis [email protected]

Solves #1939

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

Go Published Test Results

1 772 tests   1 772 ✔️  2m 35s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit 71d8f86.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Base: 82.38% // Head: 82.38% // No change to project coverage 👍

Coverage data is based on head (71d8f86) compared to base (1394f4e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2163   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         121      121           
  Lines       18476    18476           
=======================================
  Hits        15221    15221           
  Misses       2468     2468           
  Partials      787      787           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

E2E Tests Published Test Results

  1 files    1 suites   48m 45s ⏱️
89 tests 82 ✔️ 3 💤 4
93 runs  86 ✔️ 3 💤 4

For more details on these failures, see this check.

Results for commit 71d8f86.

♻️ This comment has been updated with latest results.

Copy link

@rcontreras-te rcontreras-te left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs update @kostis-codefresh !

@zachaller
Copy link
Collaborator

This looks good I do think it makes sense to possibly do a table with versions that are supported as well so we can track the history of support, thoughts? If we do this we should also make note in the release docs https://github.com/argoproj/argo-rollouts/blob/master/docs/releasing.md about updating the table until we can possibly automate it.

@kostis-codefresh
Copy link
Member Author

@zachaller FYI this is the same PR as Argo CD https://argo-cd.readthedocs.io/en/stable/operator-manual/installation/#supported-versions

It is bulletproof in the sense that it needs no updates at all.

@zachaller
Copy link
Collaborator

Yup that is fair it just makes it hard for the end users to know which versions where supported in the past without doing a whole bunch of date comparisons and looking at when argo rollouts was released and comparing it to when kubernetes was released to be able to say something like versions 1.1 of rollouts supported kubernetes versions 1.xx if we find that is to much a burden on the release to keep up to date I am fine either way nothing should block this PR. Just wanted feedback on if we felt that was useful.

Signed-off-by: Kostis Kapelonis <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@leoluz leoluz merged commit 2d6f5a0 into argoproj:master Nov 3, 2022
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
Signed-off-by: Kostis Kapelonis <[email protected]>

Signed-off-by: Kostis Kapelonis <[email protected]>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
Signed-off-by: Kostis Kapelonis <[email protected]>

Signed-off-by: Kostis Kapelonis <[email protected]>
@kostis-codefresh kostis-codefresh deleted the supported-versions branch April 18, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants