-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: mention supported versions #2163
Conversation
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportBase: 82.38% // Head: 82.38% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2163 +/- ##
=======================================
Coverage 82.38% 82.38%
=======================================
Files 121 121
Lines 18476 18476
=======================================
Hits 15221 15221
Misses 2468 2468
Partials 787 787 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docs update @kostis-codefresh !
This looks good I do think it makes sense to possibly do a table with versions that are supported as well so we can track the history of support, thoughts? If we do this we should also make note in the release docs https://github.com/argoproj/argo-rollouts/blob/master/docs/releasing.md about updating the table until we can possibly automate it. |
@zachaller FYI this is the same PR as Argo CD https://argo-cd.readthedocs.io/en/stable/operator-manual/installation/#supported-versions It is bulletproof in the sense that it needs no updates at all. |
Yup that is fair it just makes it hard for the end users to know which versions where supported in the past without doing a whole bunch of date comparisons and looking at when argo rollouts was released and comparing it to when kubernetes was released to be able to say something like versions 1.1 of rollouts supported kubernetes versions 1.xx if we find that is to much a burden on the release to keep up to date I am fine either way nothing should block this PR. Just wanted feedback on if we felt that was useful. |
Signed-off-by: Kostis Kapelonis <[email protected]>
9fed4ef
to
71d8f86
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Signed-off-by: Kostis Kapelonis <[email protected]> Signed-off-by: Kostis Kapelonis <[email protected]>
Signed-off-by: Kostis Kapelonis <[email protected]> Signed-off-by: Kostis Kapelonis <[email protected]>
Signed-off-by: Kostis Kapelonis [email protected]
Solves #1939
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.