Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide time.Parse and time.Now while evaluating notification trigger condition #2206

Merged
merged 7 commits into from
Mar 13, 2023
Merged

feat: Provide time.Parse and time.Now while evaluating notification trigger condition #2206

merged 7 commits into from
Mar 13, 2023

Conversation

mdsjip
Copy link
Contributor

@mdsjip mdsjip commented Aug 21, 2022 •
edited
Loading

Similar to argocd:

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2022 •
edited
Loading

Go Published Test Results

1 874 tests   1 874 ✔️  2m 31s ⏱️
   118 suites         0 💤
       1 files           0 ❌

Results for commit 1e38bc9.

♻️ This comment has been updated with latest results.

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 21, 2022 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5359bad) 81.50% compared to head (1e38bc9) 81.51%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2206   +/-   ##
=======================================
  Coverage   81.50%   81.51%           
=======================================
  Files         133      133           
  Lines       19852    19859    +7     
=======================================
+ Hits        16181    16188    +7     
  Misses       2836     2836           
  Partials      835      835
Impacted Files Coverage Δ
utils/record/record.go 80.08% <100.00%> (+0.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2022 •
edited
Loading

E2E Tests Published Test Results

    2 files      2 suites   1h 37m 26s ⏱️
  96 tests   90 ✔️ 3 💤   3 ❌
204 runs  187 ✔️ 6 💤 11 ❌

For more details on these failures, see this check.

Results for commit 1e38bc9.

♻️ This comment has been updated with latest results.

@zachaller zachaller added this to the v1.4 milestone Nov 8, 2022
@zachaller zachaller self-requested a review November 20, 2022 15:20
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zachaller zachaller modified the milestones: v1.4, v1.5 Dec 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zachaller zachaller changed the title feat: Provide time.Parse and time.Now while evaluating trigger condition feat: Provide time.Parse and time.Now while evaluating notification trigger condition Mar 13, 2023
@zachaller zachaller merged commit e32eaaf into argoproj:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaller zachaller zachaller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@mdsjip @zachaller