Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow Traffic shaping through header based routing for ALB #2214

Merged
merged 5 commits into from
Sep 13, 2022

Conversation

perenesenko
Copy link
Member

@perenesenko perenesenko commented Aug 25, 2022

Signed-off-by: Andrii Perenesenko [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022

E2E Tests Published Test Results

  1 files    1 suites   57m 9s ⏱️
89 tests 83 ✔️ 3 💤 3
95 runs  87 ✔️ 3 💤 5

For more details on these failures, see this check.

Results for commit 58e26b4.

♻️ This comment has been updated with latest results.

@perenesenko perenesenko changed the title Allow Traffic shaping through header based routing for ALB feat: Allow Traffic shaping through header based routing for ALB Aug 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022

Go Published Test Results

1 766 tests   1 766 ✔️  2m 34s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit 58e26b4.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #2214 (58e26b4) into master (669f961) will decrease coverage by 0.00%.
The diff coverage is 84.97%.

@@            Coverage Diff             @@
##           master    #2214      +/-   ##
==========================================
- Coverage   82.39%   82.38%   -0.01%     
==========================================
  Files         121      121              
  Lines       18099    18425     +326     
==========================================
+ Hits        14912    15179     +267     
- Misses       2417     2461      +44     
- Partials      770      785      +15     
Impacted Files Coverage Δ
rollout/trafficrouting/alb/alb.go 78.25% <73.11%> (-4.86%) ⬇️
ingress/alb.go 93.40% <90.90%> (-3.15%) ⬇️
pkg/apis/rollouts/validation/validation.go 95.57% <95.65%> (-0.11%) ⬇️
utils/ingress/wrapper.go 92.32% <98.16%> (+2.48%) ⬆️
utils/defaults/defaults.go 89.10% <100.00%> (+0.43%) ⬆️
utils/ingress/ingress.go 100.00% <100.00%> (ø)
rollout/trafficrouting/istio/controller.go 50.81% <0.00%> (-1.63%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@perenesenko perenesenko marked this pull request as ready for review August 29, 2022 17:27
utils/ingress/ingress.go Show resolved Hide resolved
utils/ingress/ingress.go Show resolved Hide resolved
utils/ingress/wrapper.go Show resolved Hide resolved
utils/ingress/wrapper.go Show resolved Hide resolved
utils/ingress/ingress.go Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

No Coverage information No Coverage information
8.9% 8.9% Duplication

@zachaller zachaller added the ready-for-review Ready for final review label Sep 9, 2022
@leoluz leoluz merged commit 4848fb1 into argoproj:master Sep 13, 2022
daixijun pushed a commit to daixijun/argo-rollouts that referenced this pull request Sep 27, 2022
…oproj#2214)

* Allow Traffic shaping through header based routing for ALB

Signed-off-by: Andrii Perenesenko <[email protected]>

* Allow Traffic shaping through header based routing for ALB. Fix test

Signed-off-by: Andrii Perenesenko <[email protected]>

* Allow Traffic shaping through header based routing for ALB. Increase coverage

Signed-off-by: Andrii Perenesenko <[email protected]>

* fix after review: deprecate field

Signed-off-by: Andrii Perenesenko <[email protected]>

* fix after review: sort http paths

Signed-off-by: Andrii Perenesenko <[email protected]>

Signed-off-by: Andrii Perenesenko <[email protected]>
Signed-off-by: Xijun Dai <[email protected]>
jenciso pushed a commit to jenciso/argo-rollouts that referenced this pull request Oct 25, 2022
…oproj#2214)

* Allow Traffic shaping through header based routing for ALB

Signed-off-by: Andrii Perenesenko <[email protected]>

* Allow Traffic shaping through header based routing for ALB. Fix test

Signed-off-by: Andrii Perenesenko <[email protected]>

* Allow Traffic shaping through header based routing for ALB. Increase coverage

Signed-off-by: Andrii Perenesenko <[email protected]>

* fix after review: deprecate field

Signed-off-by: Andrii Perenesenko <[email protected]>

* fix after review: sort http paths

Signed-off-by: Andrii Perenesenko <[email protected]>

Signed-off-by: Andrii Perenesenko <[email protected]>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
…oproj#2214)

* Allow Traffic shaping through header based routing for ALB

Signed-off-by: Andrii Perenesenko <[email protected]>

* Allow Traffic shaping through header based routing for ALB. Fix test

Signed-off-by: Andrii Perenesenko <[email protected]>

* Allow Traffic shaping through header based routing for ALB. Increase coverage

Signed-off-by: Andrii Perenesenko <[email protected]>

* fix after review: deprecate field

Signed-off-by: Andrii Perenesenko <[email protected]>

* fix after review: sort http paths

Signed-off-by: Andrii Perenesenko <[email protected]>

Signed-off-by: Andrii Perenesenko <[email protected]>
bentzys pushed a commit to bentzys/argo-rollouts that referenced this pull request Nov 22, 2022
…oproj#2214)

* Allow Traffic shaping through header based routing for ALB

Signed-off-by: Andrii Perenesenko <[email protected]>

* Allow Traffic shaping through header based routing for ALB. Fix test

Signed-off-by: Andrii Perenesenko <[email protected]>

* Allow Traffic shaping through header based routing for ALB. Increase coverage

Signed-off-by: Andrii Perenesenko <[email protected]>

* fix after review: deprecate field

Signed-off-by: Andrii Perenesenko <[email protected]>

* fix after review: sort http paths

Signed-off-by: Andrii Perenesenko <[email protected]>

Signed-off-by: Andrii Perenesenko <[email protected]>
(cherry picked from commit 4848fb1)
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
…oproj#2214)

* Allow Traffic shaping through header based routing for ALB

Signed-off-by: Andrii Perenesenko <[email protected]>

* Allow Traffic shaping through header based routing for ALB. Fix test

Signed-off-by: Andrii Perenesenko <[email protected]>

* Allow Traffic shaping through header based routing for ALB. Increase coverage

Signed-off-by: Andrii Perenesenko <[email protected]>

* fix after review: deprecate field

Signed-off-by: Andrii Perenesenko <[email protected]>

* fix after review: sort http paths

Signed-off-by: Andrii Perenesenko <[email protected]>

Signed-off-by: Andrii Perenesenko <[email protected]>
bentzys pushed a commit to bentzys/argo-rollouts that referenced this pull request Nov 28, 2022
…oproj#2214)

* Allow Traffic shaping through header based routing for ALB

Signed-off-by: Andrii Perenesenko <[email protected]>

* Allow Traffic shaping through header based routing for ALB. Fix test

Signed-off-by: Andrii Perenesenko <[email protected]>

* Allow Traffic shaping through header based routing for ALB. Increase coverage

Signed-off-by: Andrii Perenesenko <[email protected]>

* fix after review: deprecate field

Signed-off-by: Andrii Perenesenko <[email protected]>

* fix after review: sort http paths

Signed-off-by: Andrii Perenesenko <[email protected]>

Signed-off-by: Andrii Perenesenko <[email protected]>
(cherry picked from commit 4848fb1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants