Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification not sent when the conditions are not set #2228

Closed
RaviHari opened this issue Sep 5, 2022 · 0 comments · Fixed by #2231
Closed

Notification not sent when the conditions are not set #2228

RaviHari opened this issue Sep 5, 2022 · 0 comments · Fixed by #2231
Labels
bug Something isn't working

Comments

@RaviHari
Copy link
Contributor

RaviHari commented Sep 5, 2022

The issues is related to: #2066

Notifications are working when run on v1.2.2 but when upgraded v1.3.0-rc versions Notifications are not sent when conditions are not mentioned.

The logs are being generated though:

INFO[0115] Rollout has waited the duration of the pause step  namespace=rollout-canary rollout=rollouts-demo
DEBU[0115] No configured template for trigger: on-rollout-step-completed  namespace=rollout-canary rollout=rollouts-demo
INFO[0115] Event(v1.ObjectReference{Kind:"Rollout", Namespace:"rollout-canary", Name:"rollouts-demo", UID:"b3fbd661-423f-4e1f-a15b-175e9fca5f35", APIVersion:"argoproj.io/v1alpha1", ResourceVersion:"21533943", FieldPath:""}): type: 'Normal' reason: 'RolloutStepCompleted' Rollout step 7/7 completed (pause: 5) 
DEBU[0115] Notification sent                             namespace=rollout-canary rollout=rollouts-demo time_ms=0.041305
INFO[0115] Rollout step 7/7 completed (pause: 5)         event_reason=RolloutStepCompleted namespace=rollout-canary rollout=rollouts-demo
DEBU[0116] No configured destinations for trigger: on-rollout-resumed  namespace=rollout-canary rollout=rollouts-demo
DEBU[0116] Notification sent                             namespace=rollout-canary rollout=rollouts-demo time_ms=0.062244999999999995
@RaviHari RaviHari added the bug Something isn't working label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant